Fix importing files with dots #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm... Any movement on this. |
|
Merge conflicts :( |
eppsilon
force-pushed
the
fix-importing-files-with-dots
branch
from
8025bbc
to
b158799
Compare
|
I updated the branch with the following changes:
|
|
Will this get merged? |
|
I created this PR in November and rebased it in February, so...not looking likely. @Snugug ? |
|
@Snugug happy new year! could this be merged some how? or do you want to have more simplified PR on this topic? |
|
@eppsilon @TheSharpieOne @ivanvoznyakovsky @johannestroeger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was forked from @JohnAlbin's branch from #19. It would probably be best to merge that before reviewing this, or you can just look at commit 8025bbc.